[PATCH] D124183: [InstCombine] Add one use limitation for (X * C2) << C1 --> X * (C2 << C1)

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D124183#3483877 <https://reviews.llvm.org/D124183#3483877>, @bcl5980 wrote:

> Do you think we need to remove these one-use?
> If yes I will start on work it to help improve code consistent.

Some of these may be intentionally limited to one-use while others were just coded conservatively to avoid controversy.

As I said earlier, I don't think it is possible to be 100% consistent (without a lot of work in the backend). So I think it would be better to spend your time on problems that will give us a known improvement instead of a theoretical improvement. There are many open issues for optimization, or you can look for new opportunities by analyzing real applications.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124183/new/

https://reviews.llvm.org/D124183