[PATCH] D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error

Tobias Hieta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 2 05:22:28 PDT 2022


thieta added a comment.

In D124153#3485469 <https://reviews.llvm.org/D124153#3485469>, @aaron.ballman wrote:

> LGTM!
>
> I applied the patch locally and tried it out with the MSVC built-in CMake support and confirmed that everything still works as I'd expect.

Ah yes - I forgot to comment that I already have tested this! But yeah the check already did test for multi-configuration generators.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153



More information about the llvm-commits mailing list