[PATCH] D124743: [DAGCombine] Add node in the worklist in topological order in CombineTo

Amaury SECHET via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 1 13:18:35 PDT 2022


deadalnix created this revision.
deadalnix added reviewers: t.p.northover, fhahn, dblaikie, RKSimon, craig.topper, spatel.
Herald added subscribers: StephenFan, ecnelises, steven.zhang, pengfei, hiraditya.
Herald added a project: All.
deadalnix requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is part of an ongoing effort toward making DAGCombine porcess the node sin topological order.

This is able to discover a couple of new optimizations, but also causes a couple of regression. I nevertheless chose to submit this patch for review as to start the discussion with people working ont he backend so we can find a good way forward.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D124743

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/test/CodeGen/AArch64/arm64-abi-varargs.ll
  llvm/test/CodeGen/AArch64/pr51476.ll
  llvm/test/CodeGen/AArch64/swifterror.ll
  llvm/test/CodeGen/ARM/and-load-combine.ll
  llvm/test/CodeGen/ARM/swifterror.ll
  llvm/test/CodeGen/X86/and-with-overflow.ll
  llvm/test/CodeGen/X86/movmsk-cmp.ll
  llvm/test/CodeGen/X86/or-with-overflow.ll
  llvm/test/CodeGen/X86/pr51175.ll
  llvm/test/CodeGen/X86/vector-mulfix-legalize.ll
  llvm/test/CodeGen/X86/xor-with-overflow.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124743.426309.patch
Type: text/x-patch
Size: 12974 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220501/16e2d2ee/attachment.bin>


More information about the llvm-commits mailing list