[PATCH] D120960: [M68k][Disassembler] Adopt the new variable length decoder

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added a comment.

just want to double check: all of the previously-XFAIL tests are now passing, right?



================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:23
 #include "llvm/MC/MCDisassembler/MCDisassembler.h"
+#include "llvm/MC/MCFixedLenDisassembler.h"
 #include "llvm/MC/MCInst.h"
----------------
I'm wonder if we want to rename this file as well?


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:122
+    unsigned i = Insn.getBitWidth();
+    unsigned RoundUp = ((InstrBits + 0xf) & ~0xf);
+    Insn = Insn.zextOrSelf(RoundUp);
----------------
is it possible to use `llvm::alignTo` here? 


================
Comment at: llvm/lib/Target/M68k/Disassembler/M68kDisassembler.cpp:117
+  };
+  APInt insn = APInt(16, support::endian::read16be(Bytes.data()));
+  Result = decodeInstruction(DecoderTable80, Instr, insn, Address, this, STI,
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120960/new/

https://reviews.llvm.org/D120960