[PATCH] D123902: [llvm-objcopy][ObjectYAML][mips] Add MIPS specific ELF section indexes

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/ObjCopy/ELF/ELFObject.h:624
+  SYMBOL_MIPS_SCOMMON = ELF::SHN_MIPS_SCOMMON,
+  SYMBOL_MIPS_SUNDEFINED = ELF::SHN_MIPS_SUNDEFINED,
   SYMBOL_HEXAGON_SCOMMON = ELF::SHN_HEXAGON_SCOMMON,
----------------
Move MIPS after HEXAGON to keep an alphabetical order for arch-specific values.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/mips-symbol.test:25
+
+#CHECK:     Symbols [
+#CHECK-NEXT:   Symbol {
----------------
Add a space for all lines below


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123902/new/

https://reviews.llvm.org/D123902