[PATCH] D105986: [SLP]Improve vectorization of gathered loads.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.
Herald added a project: All.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:2249
+  /// try to vectorize them at the end, if profitable.
+  SmallVector<SmallVector<std::pair<LoadInst *, int>>> GatheredLoads;
+  /// The index of the first gathered load entry in the VectorizeTree.
----------------
add newline between member variables


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:3010
+/// scatter or just simple gather.
+static LoadsState canVectorizeLoads(ArrayRef<Value *> VL, const Value *VL0,
+                                    const TargetTransformInfo &TTI,
----------------
Please can you move the canVectorizeLoads code as a NFC pre-commit so that the patch becomes smaller?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105986/new/

https://reviews.llvm.org/D105986