[PATCH] D122105: [SystemZ] Patchset for expanding memcpy/memset using at most 2 stores.

[Jonas Paulsson via Phabricator via llvm-commits]

jonpa marked 3 inline comments as done.
jonpa added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:201
+  if (VT == MVT::Untyped)
+    return false;
 
----------------
uweigand wrote:
> I'm wondering if it would be better to override findOptimalMemOpLowering and handle that check there.
Yes, probably better...



================
Comment at: llvm/lib/Target/SystemZ/SystemZISelLowering.cpp:818
+  findSplat();
+}
+
----------------
uweigand wrote:
> Maybe it would be simpler to have the `APFloat` constructor only set `isFP128` and then call into the `APInt` constructor with `FPImm.bitcastToAPInt()`.   The we also wouldn't need a separate `findSplat` routine.
Yes, that is better



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122105/new/

https://reviews.llvm.org/D122105