[PATCH] D122857: [LoopCacheAnalysis] Enable delinearization of fixed sized arrays

Sat Apr 30 19:49:51 PDT 2022

congzhe added a comment.

In D122857#3483912 <https://reviews.llvm.org/D122857#3483912>, @fhahn wrote:

> In D122857#3483652 <https://reviews.llvm.org/D122857#3483652>, @congzhe wrote:
>
>> In D122857#3483562 <https://reviews.llvm.org/D122857#3483562>, @congzhe wrote:
>>
>>> In D122857#3483554 <https://reviews.llvm.org/D122857#3483554>, @jyknight wrote:
>>>
>>>> The test case added here appears to sometimes fail due to output ordering differences. E.g. https://lab.llvm.org/buildbot/#/builders/16/builds/28225
>>>>
>>>> That failure is blamed on my revert commit -- but in my local build, the test isn't failing. Perhaps there's some nondeterminism in processing order? I might switch these to CHECK-DAG, though I don't know if that's just covering up some other underlying bug...
>>>
>>> Thanks James, I've noticed that as well - In my local build it does pass. But I should have used CHECK-DAG. Let me commit a small patch that does this.
>>
>> Fixed in https://github.com/llvm/llvm-project/commit/97b8a54b25f326cac8324e0ee3adde271799951c
>
> `CHECK-DAG` works around the non-determinism. The analysis should probably be fixed to print results in a deterministic fashion.

@nikic @fhahn Thanks for the comments, I posted a patch D124725 <https://reviews.llvm.org/D124725> to fix the nondeterminism order, I'd appreciate your comments.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122857/new/

https://reviews.llvm.org/D122857