[PATCH] D123198: [LibCalls] Add argument extension attributes to more functions.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 30 17:47:04 PDT 2022
efriedma added inline comments.
================
Comment at: llvm/lib/Transforms/Utils/BuildLibCalls.cpp:1277
+ StringRef FuncName = TLI->getName(TheLibFunc);
+ return TLI->has(TheLibFunc) && !M->getNamedAlias(FuncName);
+}
----------------
Not sure `!M->getNamedAlias(FuncName)` is quite sufficient. What happens if we find a GlobalVariable? Or a Function with the wrong type?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123198/new/
https://reviews.llvm.org/D123198
More information about the llvm-commits
mailing list