[PATCH] D123381: [SelectionDAG] Remove duplicate "is scaled" information from gather/scatter SDNodes.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ISDOpcodes.h:1357-1366
 inline bool isIndexTypeSigned(MemIndexType IndexType) {
-  return IndexType == SIGNED_SCALED || IndexType == SIGNED_UNSCALED;
+  return IndexType == SIGNED_SCALED;
 }
 
 inline MemIndexType getSignedIndexType(MemIndexType IndexType) {
-  return isIndexTypeScaled(IndexType) ? SIGNED_SCALED : SIGNED_UNSCALED;
+  return SIGNED_SCALED;
 }
----------------
With scaling removed, there's a decision to be made regarding whether to keep the `IndexType` enum or just represent the signed information as a bool.  So I figured I'd maintain these now seemingly redundant helper functions until the best option is decided.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123381/new/

https://reviews.llvm.org/D123381