[PATCH] D119671: [ObjectYAML][MachO] Add basic chained fixups support

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 30 12:54:18 PDT 2022


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: StephenFan.
Herald added a project: All.

LGTM



================
Comment at: llvm/lib/ObjectYAML/MachOEmitter.cpp:522
+      ChainedFixupsCmd = &LC.Data.linkedit_data_command_data;
+      WriteQueue.push_back(std::make_pair(ChainedFixupsCmd->dataoff,
+                                          &MachOWriter::writeChainedFixups));
----------------
emplace_back


================
Comment at: llvm/lib/ObjectYAML/MachOEmitter.cpp:527
+      DyldExportsTrieCmd = &LC.Data.linkedit_data_command_data;
+      WriteQueue.push_back(std::make_pair(DyldExportsTrieCmd->dataoff,
+                                          &MachOWriter::writeDyldExportsTrie));
----------------
emplace_back


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119671/new/

https://reviews.llvm.org/D119671



More information about the llvm-commits mailing list