[PATCH] D123394: [CodeGen] Late cleanup of redundant address/immediate definitions.

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 30 08:21:04 PDT 2022


jonpa added inline comments.


================
Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:1492-1495
+  while (Change) {
+    Change = false;
+    for (auto &MBB : Worklist)
+      if (!Visited.count(MBB) && allPredsVisited(MBB)) {
----------------
arsenm wrote:
> Can't you use one of the existing block visiting iterators?
Using breadth_first() seems to work well (very nearly NFC on SPEC17).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123394/new/

https://reviews.llvm.org/D123394



More information about the llvm-commits mailing list