[PATCH] D124698: [NVPTX] Add add.cc/addc.cc/sub.cc/subc.cc for i64

[Dmitry Vassiliev via Phabricator via llvm-commits]

slydiman marked an inline comment as done.
slydiman added inline comments.


================
Comment at: llvm/test/CodeGen/NVPTX/add-sub-128bit.ll:3
+; RUN: llc < %s -march=nvptx -mcpu=sm_20 -mattr=+ptx43 | FileCheck %s --check-prefixes=CHECK,PTX43
+; RUN: %if ptxas %{ llc < %s -march=nvptx -mcpu=sm_20 | %ptxas-verify %}
+
----------------
tra wrote:
> We should add ptxas test for ptx43+ here, too.
I will collaborate with @asavonic to do this.


================
Comment at: llvm/test/CodeGen/NVPTX/add-sub-128bit.ll:8
+; CHECK-LABEL: test_add
+define i128 @test_add(i128 %a, i128 %b) {
+; DEFAULT:        add.s64
----------------
tra wrote:
> Can you think of a way to test 32-bit sub/add-with-carry that the patch makes legal? 
> We can't use the same approach as we do here with i128 as we'd just end up with a regular 64-bit add/sub.
> 
Sure. I need some time for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124698/new/

https://reviews.llvm.org/D124698