[llvm] 5aa1a7b - [RISCV] Remove 'frameindex' from list for ComplexPattern. NFC

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 29 17:43:52 PDT 2022


Author: Craig Topper
Date: 2022-04-29T17:41:07-07:00
New Revision: 5aa1a7b307ee7b8d2278f6cba0b3cc31adaaf76b

URL: https://github.com/llvm/llvm-project/commit/5aa1a7b307ee7b8d2278f6cba0b3cc31adaaf76b
DIFF: https://github.com/llvm/llvm-project/commit/5aa1a7b307ee7b8d2278f6cba0b3cc31adaaf76b.diff

LOG: [RISCV] Remove 'frameindex' from list for ComplexPattern. NFC

Putting a node in this list allows the node to be used as the root
of an isel pattern that would then call the ComplexPattern. The
usual case is to use the ComplexPattern as the operand of another
operator.

AddrFI is never used as a root operation. frameindex is handled
directly with custom code in RISCVISelDAGToDAG::Select. So adding
frameindex to the list here serves no purpose.

Added: 
    

Modified: 
    llvm/lib/Target/RISCV/RISCVInstrInfo.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/RISCV/RISCVInstrInfo.td b/llvm/lib/Target/RISCV/RISCVInstrInfo.td
index cb28a2473270..5034e380c9ae 100644
--- a/llvm/lib/Target/RISCV/RISCVInstrInfo.td
+++ b/llvm/lib/Target/RISCV/RISCVInstrInfo.td
@@ -367,7 +367,7 @@ def uimm6gt32 : ImmLeaf<XLenVT, [{
 
 // Addressing modes.
 // Necessary because a frameindex can't be matched directly in a pattern.
-def AddrFI : ComplexPattern<iPTR, 1, "SelectAddrFI", [frameindex], []>;
+def AddrFI : ComplexPattern<iPTR, 1, "SelectAddrFI">;
 def BaseAddr : ComplexPattern<iPTR, 1, "SelectBaseAddr">;
 
 // Return the negation of an immediate value.


        


More information about the llvm-commits mailing list