[PATCH] D122857: [LoopCacheAnalysis] Enable delinearization of fixed sized arrays

Congzhe Cao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 29 15:59:51 PDT 2022


congzhe added a comment.

In D122857#3483562 <https://reviews.llvm.org/D122857#3483562>, @congzhe wrote:

> In D122857#3483554 <https://reviews.llvm.org/D122857#3483554>, @jyknight wrote:
>
>> The test case added here appears to sometimes fail due to output ordering differences. E.g. https://lab.llvm.org/buildbot/#/builders/16/builds/28225
>>
>> That failure is blamed on my revert commit -- but in my local build, the test isn't failing. Perhaps there's some nondeterminism in processing order? I might switch these to CHECK-DAG, though I don't know if that's just covering up some other underlying bug...
>
> Thanks James, I've noticed that as well - In my local build it does pass. But I should have used CHECK-DAG. Let me commit a small patch that does this.

Fixed in https://github.com/llvm/llvm-project/commit/97b8a54b25f326cac8324e0ee3adde271799951c


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122857/new/

https://reviews.llvm.org/D122857



More information about the llvm-commits mailing list