[PATCH] D124698: [NVPTX] Add add.cc/addc.cc/sub.cc/subc.cc for i64

[Artem Belevich via Phabricator via llvm-commits]

tra added inline comments.


================
Comment at: llvm/lib/Target/NVPTX/NVPTXISelLowering.cpp:490
 
+  setOperationAction(ISD::ADDC, MVT::i32, Legal);
+  setOperationAction(ISD::ADDE, MVT::i32, Legal);
----------------
BTW, `ADDC/SUBC` are apparently deprecated in favor of `ADDCARRY/SUBCARRY`
https://github.com/llvm/llvm-project/blob/a83f4b9cda57c5b3d414ec3bcf9ac891b2ec27e1/llvm/include/llvm/CodeGen/ISDOpcodes.h#L269

Perhaps those should be added as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124698/new/

https://reviews.llvm.org/D124698