[PATCH] D124615: [AArch64][SVE] Restore SP from FP when SVE CSRs and variable sized objects are present

[Eli Friedman via Phabricator via llvm-commits]

efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with a minor comment.



================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1958
+    // stack as being realigned, so as to restore the stack pointer prior to
+    // SVE CSR restoration.
+    if (AFI->isStackRealigned() || MFI.hasVarSizedObjects()) {
----------------
This comment is a bit misleading.  For some reading this for the first time, there isn't any presumption that this is for realignment specifically.

Maybe just "If we have stack realignment or variable sized objects on the stack, we must restore the stack pointer using the frame pointer".  Or something like that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124615/new/

https://reviews.llvm.org/D124615