[PATCH] D123198: [LibCalls] Add argument extension attributes to more functions.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 29 11:08:13 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/BuildLibCalls.cpp:1217
+  // zero extensions as needed.
+  Function *F = M->getFunction(Name);
+  assert(F && "Expected a Function in Module for the library function.");
----------------
Instead of calling getFunction(), should we just `cast<Function>(C.getCallee())`?

Actually, also, should we check that the type of the Function is actually "T"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123198/new/

https://reviews.llvm.org/D123198



More information about the llvm-commits mailing list