[PATCH] D124678: [AMDGPU] Allow for MFMA Inst Clustering

Fri Apr 29 10:05:35 PDT 2022

jrbyrnes added inline comments.

================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:856
+      if (!TII->isMAI(MAI) ||
+          MAI.getOpcode() == AMDGPU::V_ACCVGPR_WRITE_B32_e64 ||
+          MAI.getOpcode() == AMDGPU::V_ACCVGPR_READ_B32_e64)
----------------
rampitec wrote:
> arsenm wrote:
> > What about copies before they are lowered to accvgpr_write?
> They are not MAI. This ideom used to filter MFMA from 2 other MAI encoded instructions.
Thanks for your comments. I looked into it, and these types of copies are not flagged as MAI to begin with -- the check to exclude accvgpr_write is thus irrelevant.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124678/new/

https://reviews.llvm.org/D124678