[PATCH] D124153: [CMake] Make omitting CMAKE_BUILD_TYPE an error

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added inline comments.


================
Comment at: llvm/CMakeLists.txt:70-75
+  * -DCMAKE_BUILD_TYPE=Release - For optimized build with no assertions or debug info.
+  * -DCMAKE_BUILD_TYPE=Debug - For unoptimized build with assertions and debug info.
+  * -DCMAKE_BUILD_TYPE=RelWithDebInfo - For optimized build with no assertions but with debug info.
+  * -DCMAKE_BUILD_TYPE=MinSizeRel - Build optimized for size instead of speed.
+Learn more about these options and which value is right for your use case in our documentation:
+https://llvm.org/docs/CMake.html
----------------
Minor wording suggestions.


================
Comment at: llvm/docs/ReleaseNotes.rst:72-74
+* Omitting CMAKE_BUILD_TYPE when using a single configuration generator is now
+  an error. You now have to pass -DCMAKE_BUILD_TYPE=<type> in order to configure
+  LLVM.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124153/new/

https://reviews.llvm.org/D124153