[PATCH] D123599: [DebugInfo][InstrRef] Describe value sizes when spilt to stack

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

To explain my thinking -- coroutines recently started using dbg.addr, and can be salvaged in 0b647fc529 <https://reviews.llvm.org/rG0b647fc5299156bf83c46aa539d6c9c39647bb36>, which will create complex DIExpressions (aka anything with a DW_OP_stack_value). I think this might be the first scenario where dbg.addrs are generated and can be salvaged, which then messes up other code I've written in SelectionDAG, that assumes a dbg.addr can be treated as a more specific dbg.declare. If so, the fix is probably to flush the indirectness out of the intrinsics/instructions at SelectionDAG, seeing how everyone wants the IsIndirect flag gone in the long run.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123599/new/

https://reviews.llvm.org/D123599