[PATCH] D124514: [ArgPromotion] Make a non-byval promotion attempt first

[Pavel Samolysov via Phabricator via llvm-commits]

psamolysov marked an inline comment as done.
psamolysov added a comment.

@nikic Thank you for the explanation, I think the `IsSafeToPromote` variable should be used as a flag whether using the argument in stores is allowed and taking into account within the `findArgParts` function.  That refactoring is much larger than the proposed here, so it deserves another review.



================
Comment at: llvm/lib/Transforms/IPO/ArgumentPromotion.cpp:842
+                     std::back_inserter(Types),
+                     [](const auto &Pair) { return Pair.second.Ty; });
+
----------------
nikic wrote:
> This std::transform makes the code both longer and harder to read.
True, I've returned the loop back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124514/new/

https://reviews.llvm.org/D124514