[PATCH] D122563: [RISCV] Add DAGCombine to fold base operation and reduction.

[Yeting Kuo via Phabricator via llvm-commits]

fakepaper56 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:8454
+  case ISD::FADD:
+    return performFADDCombine(N, DAG);
+  case ISD::UMAX:
----------------
craig.topper wrote:
> craig.topper wrote:
> > craig.topper wrote:
> > > Can we just lump all these together calling combineBinOpToReduce directly until we need specific combines for them?
> > This wasn't addressed. I don't think we want individual performUMAXCombine, performUMINCombine, etc. functions.
> Please address this comment and I will approve this patch.
I had lumped them together and call combineBinOpToReduce directly in the latest update.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122563/new/

https://reviews.llvm.org/D122563