[PATCH] D122602: [CSSPGO] Rename ProfileIsCSNested and ProfileIsCSFlat

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/tools/llvm-profgen/CSPreInliner.cpp:200
+      // is a preinliner-computed profile.
+      FunctionSamples::ProfileIsPreInlined = true;
       FuncFinalSize += Candidate.SizeCost;
----------------
hoy wrote:
> wenlei wrote:
> > I think we should set this in `CSPreInliner::run()`? In theory even if preinliner did nothing to the input profile, as long as we run it, the profile should be considered preinlined. 
> > 
> > That also avoids setting it in the loop, for each function.
> Sounds good.
For the case I mentioned, how do we mark a profile as preinlined for text profile though, if no context actually has the preinline bit, but preinliner was run? 

Admittedly this is a very corner case.. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122602/new/

https://reviews.llvm.org/D122602