[PATCH] D124361: [Coroutines] Add coro_maychange intrinsic to solve TLS problem (2/5)
Chuanqi Xu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 28 20:20:47 PDT 2022
ChuanqiXu updated this revision to Diff 425954.
ChuanqiXu added a comment.
Address comments:
- Don't add filter for OpenMP
- Add `readonly` and `inaccessiblememonly` attribute to llvm.coro.may_change intrinsics.
---
I think it is better to discuss whether or not to insert llvm.coro.may_change in non-coroutines in discourse: https://discourse.llvm.org/t/address-thread-identification-problems-with-coroutine/62015
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124361/new/
https://reviews.llvm.org/D124361
Files:
clang/lib/CodeGen/CGExpr.cpp
clang/test/CodeGenCXX/const-init-cxx2a.cpp
clang/test/CodeGenCXX/cxx2a-thread-local-constinit.cpp
clang/test/CodeGenCoroutines/coro-tls.cpp
llvm/docs/Coroutines.rst
llvm/include/llvm/IR/IRBuilder.h
llvm/include/llvm/IR/Intrinsics.td
llvm/lib/IR/IRBuilder.cpp
llvm/lib/Transforms/Coroutines/CoroCleanup.cpp
llvm/lib/Transforms/Coroutines/Coroutines.cpp
llvm/lib/Transforms/Utils/InlineFunction.cpp
llvm/test/Transforms/Coroutines/coro-TLS-01.ll
llvm/test/Transforms/Coroutines/coro-TLS-02.ll
llvm/test/Transforms/Coroutines/coro-TLS-03.ll
llvm/test/Transforms/Coroutines/coro-TLS-04.ll
llvm/test/Transforms/Coroutines/coro-cleanup-maychange.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124361.425954.patch
Type: text/x-patch
Size: 25069 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220429/7b3550e4/attachment.bin>
More information about the llvm-commits
mailing list