[PATCH] D124643: [Object][DX] Initial DXContainer parsing support

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/BinaryFormat/DXContainer.h:65
+
+// ┌────────────────────────────────┐
+// │             Header             │
----------------
This comment just seems to duplicate what the code says.

If you just write `uint8_t Magic[4]; // "DXBC"`, it seems to cover all the reader needs.


================
Comment at: llvm/include/llvm/BinaryFormat/DXContainer.h:95
+
+// ┌────────────────────────────────┐
+// │              Part              │
----------------
The comment doesn't convey more information than the code says.


================
Comment at: llvm/lib/Object/DXContainer.cpp:37
+
+llvm::Error DXContainer::parseHeader() {
+  return readStruct(Data.getBuffer(), Data.getBuffer().data(), Header);
----------------
Omit llvm::


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124643/new/

https://reviews.llvm.org/D124643