[PATCH] D124626: [AMDGPU] Produce waitcounts for LDS DMA

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 16:56:56 PDT 2022


rampitec added a comment.

I also feel like EXTRA_VGPR_LDS was made specifically for this scenario, when we have no VGPR result to track dependency. And it was unused and dead code. Unfortunately we practically do not have tests for this pass and this place is certainly not covered. If I remove isDS() call nothing fails, but probably it should not and it was dead. I cannot prove it though as I have no idea what was originally behind it. But that fit so well, so I guess it was DMA.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124626/new/

https://reviews.llvm.org/D124626



More information about the llvm-commits mailing list