[PATCH] D122602: [CSSPGO] Rename ProfileIsCSNested and ProfileIsCSFlat
Wenlei He via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 28 16:26:07 PDT 2022
wenlei added inline comments.
================
Comment at: llvm/tools/llvm-profgen/CSPreInliner.cpp:200
+ // is a preinliner-computed profile.
+ FunctionSamples::ProfileIsPreInlined = true;
FuncFinalSize += Candidate.SizeCost;
----------------
I think we should set this in `CSPreInliner::run()`? In theory even if preinliner did nothing to the input profile, as long as we run it, the profile should be considered preinlined.
That also avoids setting it in the loop, for each function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122602/new/
https://reviews.llvm.org/D122602
More information about the llvm-commits
mailing list