[llvm] 75881d8 - [NFC] const-ed the return type of FunctionPropertiesAnalysis

Mircea Trofin via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 12:42:27 PDT 2022


Author: Mircea Trofin
Date: 2022-04-28T12:42:16-07:00
New Revision: 75881d8b023ef8576afbba510c07eb8b899f2ec7

URL: https://github.com/llvm/llvm-project/commit/75881d8b023ef8576afbba510c07eb8b899f2ec7
DIFF: https://github.com/llvm/llvm-project/commit/75881d8b023ef8576afbba510c07eb8b899f2ec7.diff

LOG: [NFC] const-ed the return type of FunctionPropertiesAnalysis

The result is a data bag, this makes sure it's signaled to a user that
the data can't be mutated when, for example, doing something like:

auto &R = FAM.getResult<FunctionPropertiesAnalysis>(F)
...
R.Uses++

Added: 
    

Modified: 
    llvm/include/llvm/Analysis/FunctionPropertiesAnalysis.h
    llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Analysis/FunctionPropertiesAnalysis.h b/llvm/include/llvm/Analysis/FunctionPropertiesAnalysis.h
index 81913f15f1ec..ef4a1bb110e3 100644
--- a/llvm/include/llvm/Analysis/FunctionPropertiesAnalysis.h
+++ b/llvm/include/llvm/Analysis/FunctionPropertiesAnalysis.h
@@ -66,7 +66,7 @@ class FunctionPropertiesAnalysis
 public:
   static AnalysisKey Key;
 
-  using Result = FunctionPropertiesInfo;
+  using Result = const FunctionPropertiesInfo;
 
   Result run(Function &F, FunctionAnalysisManager &FAM);
 };

diff  --git a/llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp b/llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp
index 1dc90422ca7b..df895328a9a2 100644
--- a/llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp
+++ b/llvm/lib/Analysis/FunctionPropertiesAnalysis.cpp
@@ -73,7 +73,7 @@ void FunctionPropertiesInfo::print(raw_ostream &OS) const {
 
 AnalysisKey FunctionPropertiesAnalysis::Key;
 
-FunctionPropertiesInfo
+const FunctionPropertiesInfo
 FunctionPropertiesAnalysis::run(Function &F, FunctionAnalysisManager &FAM) {
   return FunctionPropertiesInfo::getFunctionPropertiesInfo(
       F, FAM.getResult<LoopAnalysis>(F));


        


More information about the llvm-commits mailing list