[PATCH] D124631: [TwoAddressInstructionPass] Special processing of STATEPOINT instruction.

[Matthias Braun via Phabricator via llvm-commits]

MatzeB added a comment.

Sorry I am not up-to-speed with how STATEPOINTs work in detail. But this change is confusing me and probably needs the description reworked:

- The summary reads like somehow the lifetime for any `STATEPOINT` operand must end at the `STATEPOINT`.
- The comment above `TwoAddressInstructionPass::processStatepoint` shows the exact opposite and lengthens the lifetime of the operand register.

Also given that this is a targetted change to the twoaddressinstruction pass it would be good to have at least 1 test that just checks for this particular change in isolation! (the `statepoint-invoke-ra.mir` is running multiple passes in succession and doesn't make it clear what exactly changed).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124631/new/

https://reviews.llvm.org/D124631