[PATCH] D124626: [AMDGPU] Produce waitcounts for LDS DMA

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 11:37:15 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:502-503
+static bool mayWriteLDSThroughDMA(const MachineInstr &MI) {
+  return SIInstrInfo::isVALU(MI) &&
+         (SIInstrInfo::isMUBUF(MI) || SIInstrInfo::isFLAT(MI)) &&
+         MI.getOpcode() != AMDGPU::BUFFER_STORE_LDS_DWORD;
----------------
isVALU is redundant with isMUBUF || isFLAT?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124626/new/

https://reviews.llvm.org/D124626



More information about the llvm-commits mailing list