[PATCH] D112175: [NFC] Add llvm::StaticVector ADT

Thu Apr 28 10:54:17 PDT 2022

dblaikie added a comment.

In D112175#3092225 <https://reviews.llvm.org/D112175#3092225>, @mehdi_amini wrote:

> In D112175#3091114 <https://reviews.llvm.org/D112175#3091114>, @jplayer-nv wrote:
>
>> Here's another example of a possible StaticVector conversion:
>>
>> llvm/lib/MC/WinCOFFObjectWriter.cpp
>> ...
>
> Yeah that seems like the perfect case! (I don't think it's common in the compiler world though, but happy to be proven wrong).

Yeah, even here it seems like an assert after populating the vector isn't especially costly/problematic - for me even a bunch of those across the codebase seems hard for me to justify the several thousands of lines similar vector code/testing/etc. That's my gut feeling at the moment at least.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112175/new/

https://reviews.llvm.org/D112175