[PATCH] D119681: [LV] Rename CountRoundDown to VectorTripCount (NFC)

Thu Apr 28 09:50:46 PDT 2022

fhahn added a reviewer: Ayal.
fhahn added a comment.
Herald added a project: All.

Thanks for the patch and sorry for the delay. It's common practice to 'ping' a patch regularly (curtesy ping period is roughly every 7 days), otherwise it is very easy for patches to fall through the cracks.

The renaming makes sense to me and makes the code more consistent as a whole, as VectorTripCount is used elsewhere for the same thing already. Please move the changes unrelated to the renaming to a separate patch.

================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3602

-      IRBuilder<> B(MiddleBlock->getTerminator());

----------------
Can you limit this patch to *only* adjust `CountRoundDown` -> `VectorTripCount`? And mov eat either refactoring changes to a separate patch?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119681/new/

https://reviews.llvm.org/D119681