[PATCH] D123720: [VPlan] Replace use of needsVectorIV with VPlan user check.
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 28 09:23:19 PDT 2022
fhahn added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:432
- // If there are no vector users of IV, simply update all users to use Step
- // instead.
- if (!IV->needsVectorIV()) {
- IV->replaceAllUsesWith(Steps);
- continue;
- }
-
- // Otherwise only update scalar users of IV to use Step instead. Use
- // SetVector to ensure the list of users doesn't contain duplicates.
+ // Update scalar users of IV to use Step instead. Use SetVector to ensure the list of users doesn't contain duplicates.
SetVector<VPUser *> Users(IV->user_begin(), IV->user_end());
----------------
Ayal wrote:
> 80 columns?
>
> "to use Step[s] instead"
I realized the line length issue immediately after committing :( Should already be fixed by rG2883de05145f
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123720/new/
https://reviews.llvm.org/D123720
More information about the llvm-commits
mailing list