[PATCH] D124156: [flang][OpenMP] Added parser support for in_reduction clause on OpenMP Task directive

[Shraiysh via Phabricator via llvm-commits]

shraiysh added a comment.

> I actually checked the current files in https://github.com/llvm/llvm-project/tree/main/flang/test/Parser and wondered if I should include one file that would contain all tests related to block constructs that we include in future. Many block construct related directives are absent in the `flang/test/Parser` directory; but I wondered we can condense any block directive incoming in future into this file. Let me know what you think about this.

I am assuming you are talking about OpenMP Block constructs and not there is no block construct in core fortran. In that case, their tests should be separated IMO. "omp-parallel-unparse.f90" should be separated from "omp-task-unparse.f90" as they are easily distinguishable. Nevertheless, I don't have a very strong opinion on this and am okay with "omp-block-construct-unparse.f90" too, but please add parse tree tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124156/new/

https://reviews.llvm.org/D124156