[PATCH] D124562: [lld-macho][nfc] Set test min version to 11.0

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 28 05:36:17 PDT 2022


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

I don't have a problem with the change, but I also don't understand the motivation. llc (and clang) transparently setting the os to 11.0 for arm is a feature (there are no arm macs running 10.15). It makes it _easier_ to write your build files (want to target 10.14? set mmacosx-version-min=10.14, and it'll automatically do the right thing in the arm part of your build).

lld tests that want to test version handling want to use `%no-arg-lld` anyways so we don't have to change everything when we change this default.

So I don't get the benefit behind this change. (But I also don't see a problem with it, so feel free to land if it's useful in some way I miss!)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124562/new/

https://reviews.llvm.org/D124562



More information about the llvm-commits mailing list