[PATCH] D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint.

[Peixin Qiao via Phabricator via llvm-commits]

peixin accepted this revision.
peixin added inline comments.


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:1011
+                       Optional<I1>:$if_expr);
+  let assemblyFormat = [{ `cancel_construct` `(`
+                          custom<ClauseAttr>($cancel_construct_val) `)`
----------------
Nit: cancel_construct -> cancellation_construct_type or cancellation_type 


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:1027
+  }];
+  let arguments = (ins CancellationConstructTypeAttr:$cancel_construct_val);
+  let assemblyFormat = [{ `cancel_construct` `(`
----------------
Nit: cancel_construct_val -> cancellation_construct_type_val or cancellation_type_val


================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:1028
+  let arguments = (ins CancellationConstructTypeAttr:$cancel_construct_val);
+  let assemblyFormat = [{ `cancel_construct` `(`
+                           custom<ClauseAttr>($cancel_construct_val) `)`
----------------
Nit: cancel_construct -> cancellation_construct_type or cancellation_type 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123828/new/

https://reviews.llvm.org/D123828