[PATCH] D124514: [ArgPromotion] Allow pointer promotion if byval adds to many arguments

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

Might make sense to move the non-byval promotion attempt first and then fall back to byval? I think non-byval promotion is generally better if it's possible.

Though it would probably make sense to handle byval promotion in the same way as non-byval promotion (but allowing stores) -- I believe the current byval implementation is not correct under opaque pointers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124514/new/

https://reviews.llvm.org/D124514