[PATCH] D124367: [docs] Improve documentation around CMAKE_BUILD_TYPE

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/docs/GettingStarted.rst:77-78
+       of the build. Possible values are ``Release``, ``Debug``, ``MinSizeRel`` and
+       ``RelWithDebInfo``. The default value is ``Debug`` that fits people that want
+       to work on LLVM or with it's libraries. ``Release`` is a better fit for most
+       users of LLVM and Clang. For more detailed information see :ref:`CMAKE_BUILD_TYPE <cmake_build_type>`.
----------------
thieta wrote:
> jhenderson wrote:
> > jhenderson wrote:
> > > Do you mean "with it's libraries" i.e. someone who is developing a project using LLVM libraries? If not, it should be "or it's libraries".
> > Not addressed? Also it's -> its.
> I did change it to `or it's libraries`, will fix the other issue.
You didn't address the main bit which was the inline edit (use "which" and "who" instead of "that").


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124367/new/

https://reviews.llvm.org/D124367