[PATCH] D124367: [docs] Improve documentation around CMAKE_BUILD_TYPE

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/docs/CMake.rst:212
+  * Builds with debug information can use a lot of RAM and lot of
+    disk space and is usually slower to run. You can improve
+    RAM usage by using ``lld``, see the :ref:`LLVM_USE_LINKER <llvm_use_linker>`
----------------



================
Comment at: llvm/docs/GettingStarted.rst:77-78
+       of the build. Possible values are ``Release``, ``Debug``, ``MinSizeRel`` and
+       ``RelWithDebInfo``. The default value is ``Debug`` that fits people that want
+       to work on LLVM or with it's libraries. ``Release`` is a better fit for most
+       users of LLVM and Clang. For more detailed information see :ref:`CMAKE_BUILD_TYPE <cmake_build_type>`.
----------------
jhenderson wrote:
> Do you mean "with it's libraries" i.e. someone who is developing a project using LLVM libraries? If not, it should be "or it's libraries".
Not addressed? Also it's -> its.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124367/new/

https://reviews.llvm.org/D124367