[PATCH] D123828: [mlir][OpenMP] Add omp.cancel and omp.cancellationpoint.

[Peixin Qiao via Phabricator via llvm-commits]

peixin added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:174
+
+def OMPC_CancelConstructType : Clause<"cancellation_construct_type"> {
+  let enumClauseValue = "CancellationConstructType";
----------------
Can you update them all if you use `CancellationConstructType` for the keyword?
OMPC_CancelConstructType -> OMPC_CancellationConstructType
OMP_CANCEL_CONSTRUCT_Parallel -> OMP_CANCELLATION_CONSTRUCT_Parallel
...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123828/new/

https://reviews.llvm.org/D123828