[PATCH] D123752: [lld] Implement safe icf for MachO

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 17:10:36 PDT 2022


smeenai added inline comments.


================
Comment at: lld/MachO/InputSection.h:74
   bool isFinal = false;
+  // keep the address of the symbol unique in the final binary ?
+  bool keepUnique = false;
----------------
Nit: "symbol" is a bit confusing, since the flag is on a section. Perhaps something like this instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123752/new/

https://reviews.llvm.org/D123752



More information about the llvm-commits mailing list