[PATCH] D124560: [llvm-objdump] Symbolize branch targets and basic block addresses based on the bb-address-map when present in the object file.

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/Object/ELFObjectFile.cpp:668
+      continue;
+    llvm::Expected<std::vector<BBAddrMap>> bb_addr_map =
+        EF.decodeBBAddrMap(Sec);
----------------
Coding style: BBAddrMap (i.e. first letter capital, no '_')


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1008
+    return;
+  for (unsigned i = 0; i < Iter->second.BBEntries.size(); ++i) {
+    uint64_t BBAddress = Iter->second.BBEntries[i].Offset + Iter->second.Addr;
----------------
I (capital)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124560/new/

https://reviews.llvm.org/D124560