[PATCH] D112175: [NFC] Add llvm::StaticVector ADT

James Player via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 15:13:40 PDT 2022


jplayer-nv updated this revision to Diff 425623.
jplayer-nv added a comment.
Herald added a project: All.

Resurrecting this review for the following:

1. I defined `checked_` versions of member functions which may grow the container beyond its buffer capacity.  All `checked_` member functions return an `llvm::Error` or `llvm::Expected`.

2. I found a more compelling potential use of the `StaticVector` as the `llvm::SmallSet`'s underlying small storage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112175/new/

https://reviews.llvm.org/D112175

Files:
  llvm/include/llvm/ADT/STLExtras.h
  llvm/include/llvm/ADT/STLForwardCompat.h
  llvm/include/llvm/ADT/SmallSet.h
  llvm/include/llvm/ADT/StaticVector.h
  llvm/include/llvm/DebugInfo/CodeView/TypeRecord.h
  llvm/include/llvm/Support/YAMLTraits.h
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/unittests/ADT/CMakeLists.txt
  llvm/unittests/ADT/StaticVectorTest.cpp
  llvm/utils/LLVMVisualizers/llvm.natvis

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D112175.425623.patch
Type: text/x-patch
Size: 158957 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220427/0576facc/attachment-0001.bin>


More information about the llvm-commits mailing list