[PATCH] D118177: [llvm-profgen] Decouple artificial branch from LBR parser and fix external address related issues
Lei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 27 14:51:43 PDT 2022
wlei added a comment.
As we discussed offline, noted the summary here:
The data shows we the interrupt or standalone LBR pattern does exist, we should handle it(clear the call stack and keep unwinding).
Now we don’t choose to rely on detecting this LBR based on its type(call, return, jmp), we will leverage checking in `linearUnwind`, because a standalone LBR, no matter its type, since it doesn’t have other part to pair, it will eventually cause a wrong linear range, like [external, internal], [internal, external]. Then set the state to invalid there, this should make the code cleaner.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118177/new/
https://reviews.llvm.org/D118177
More information about the llvm-commits
mailing list