[PATCH] D124413: [llvm-ml] Improve indirect call parsing

Alan Zhao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 11:30:13 PDT 2022


ayzhao marked an inline comment as done.
ayzhao added inline comments.


================
Comment at: llvm/test/tools/llvm-ml/indirect_branch.asm:186
+t16:
+je [t16];
+; CHECK-LABEL: t16:
----------------
hans wrote:
> Do we give a decent error for "je fn_ref"?
llvm-ml seems to accept `je fn_ref` by treating `fn_ref` as a label. My guess is that llvm-ml (and perhaps other assembler dialects) are more tolerant of what can be treated as a label.

This is definitely an inconsistency, but fixing it feels like it's out of the scope of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124413/new/

https://reviews.llvm.org/D124413



More information about the llvm-commits mailing list