[PATCH] D123964: CodeGen: Replace some uses of LLVMTargetMachine with TargetMachine

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 11:15:00 PDT 2022


arsenm added a comment.

In D123964#3477815 <https://reviews.llvm.org/D123964#3477815>, @MatzeB wrote:

> The discussion in https://reviews.llvm.org/D38489 seems to indicate that the problem is that some users/binaries link `libTarget` but not `libCodeGen` and they expect `TargetMachine` to work but not `LLVMTargetMachine`.

So based on the uses with libCodeGen=TargetMachine, libTarget=LLVMTargetMachine,

usesPhysRegsForValues and unqualifiedInlineAsmVariant ared used in lib/CodeGen, so belong in TargetMachine which is what this patch does. It also tightens some of the references in libCodeGen to TargetMachine, so this patch is in line with that reasoning?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123964/new/

https://reviews.llvm.org/D123964



More information about the llvm-commits mailing list