[PATCH] D124445: [llvm-ar] Modify usage printouts to use the correct toolname

Wed Apr 27 09:47:51 PDT 2022

chrisjackson added inline comments.

================
Comment at: llvm/test/tools/llvm-ar/tool-name.test:18
+# SUFFIX: USAGE: ar
+# ARM: arm-pokymllib32-linux-gnueabi-llvm-ar-9
----------------
chrisjackson wrote:
> jhenderson wrote:
> > What's the purpose of this line? To show that the prefix is printed as much as the suffix, or something more specific?
> > 
> > Also, it's missing "USAGE:" unlike the other patterns.
> looking at https://github.com/llvm/llvm-project/commit/4d53b99c5df2c83172d23521d1b1ab8361d6de92, this exists because the tool selection heuristic would mistakenly think it was 'llvm-lib', so I have retained this check.
Actually, thinking about it, this check no longer guarantees that the correct tool has been chosed. A different line from the usage output that contains the default tool name will have to be checked

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124445/new/

https://reviews.llvm.org/D124445