[llvm] a6b355d - [SLP] Fix a typo that causes redundant assertion and potential segment fault

Shilei Tian via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 27 07:08:03 PDT 2022


Author: Shilei Tian
Date: 2022-04-27T10:07:59-04:00
New Revision: a6b355dd3164f9f906afb6ef8a44fde2651be9d5

URL: https://github.com/llvm/llvm-project/commit/a6b355dd3164f9f906afb6ef8a44fde2651be9d5
DIFF: https://github.com/llvm/llvm-project/commit/a6b355dd3164f9f906afb6ef8a44fde2651be9d5.diff

LOG: [SLP] Fix a typo that causes redundant assertion and potential segment fault

Reviewed By: ABataev

Differential Revision: https://reviews.llvm.org/D124497

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index ee0b8582a9ab..00661d1e8923 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -3293,7 +3293,7 @@ BoUpSLP::~BoUpSLP() {
 
   // Cleanup any dead scalar code feeding the vectorized instructions
   RecursivelyDeleteTriviallyDeadInstructions(DeadInsts, TLI);
-  
+
 #ifdef EXPENSIVE_CHECKS
   // If we could guarantee that this call is not extremely slow, we could
   // remove the ifdef limitation (see PR47712).
@@ -10898,7 +10898,7 @@ bool SLPVectorizerPass::vectorizeStoreChains(BoUpSLP &R) {
         DomTreeNodeBase<llvm::BasicBlock> *NodeI2 =
             DT->getNode(I2->getParent());
         assert(NodeI1 && "Should only process reachable instructions");
-        assert(NodeI1 && "Should only process reachable instructions");
+        assert(NodeI2 && "Should only process reachable instructions");
         assert((NodeI1 == NodeI2) ==
                    (NodeI1->getDFSNumIn() == NodeI2->getDFSNumIn()) &&
                "Different nodes should have 
diff erent DFS numbers");


        


More information about the llvm-commits mailing list