[PATCH] D124457: [AArch64][SVE] Only fold frame indexes referencing SVE objects into SVE loads/stores

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added a comment.

I'm inclined to agree given this patch is more mitigation rather than an actual fix.  Is it not possible to include a minimised version of the original crashing test case? just as a no crash test. I ask because otherwise somebody could easily remove this mitigation without realising the mistake.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:5105
+      return true;
+    }
   }
----------------
I know we have the `if (N.getOpcode() != ISD::ADD)` test below but I think it's better to have an explicit `return false` for invalid values for `FI`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124457/new/

https://reviews.llvm.org/D124457